fix: deprecate bnc-notify #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gsteenkamp89
approved these changes
Sep 30, 2024
pxrl
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to have been a change in the Onboard API for handling notifications. Our API key seems to not work anymore and therefore the user gets "stuck" on some flows where we await an event from Onboard's API. I also noticed that we still use the old (soon to be deprecated) Notify package.
This PR removes for now the dependency on Onboards notification and the old Notify package. The drawback is that our dApp won't have notifications temporarily. I also contacted the Onboard for a new API key which should re-enable notifications shortly